Repository navigation
List minecraft-versions.json in the README's project layout - #46
Merged
Merged
Conversation
The Supported Minecraft Versions section tells contributors to edit minecraft-versions.json, but Project Layout listed only the source, the manifest and the tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (performed inline; Copilot reviewer could not be added:
Observation outside the diff: README.md:63's No blocking findings. The PR is considered merge-ready. This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.md→ Project Layout now listsminecraft-versions.json. The README's Supported Minecraft Versions section tells contributors to add a version to that file, and both theBuildworkflow (check_api_compat.py --versions minecraft-versions.json) andDocumentationTest.versionListsMatchMinecraftVersionsJsonread it, yet the layout listed onlyMain.java,plugin.ymlandsrc/test/java/.CHANGELOG.mdgains a bullet under## [Unreleased]→### Fixed.This was the only drift found by a documentation accuracy sweep (Stage A) of
README.md,USER_GUIDE.md,COMMANDS.md,CONFIG.md,CHANGELOG.md,CONTRIBUTING.mdandplugin.ymlagainstMain.java,plugin.yml,pom.xml,minecraft-versions.jsonand the three workflows at4485d8b.No tracking issue — gap found during triage. #45 states that the README's Project Layout already lists
minecraft-versions.json; it did not, and after this PR it does, so the change suggested there for.github/copilot-instructions.mdwould match the README.Validation
mvn -o clean packageon this branch:Tests run: 13, Failures: 0, Errors: 0, Skipped: 0,BUILD SUCCESS. The same build passed onmainbefore the change..github/workflows/build.ymlpasses--versions minecraft-versions.jsonto the API check, andDocumentationTestline 46 loads the file and compares it with the version lists inREADME.mdandUSER_GUIDE.md.Dev Releaseworkflow ignores this merge.Open issues deferred this cycle
.github/copilot-instructions.md, which is agent-loaded guidance.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson